Skip to content

Strip literal freshness from type queries#25471

Merged
weswigham merged 2 commits into
microsoft:masterfrom
weswigham:typeof-strips-freshness
Jul 6, 2018
Merged

Strip literal freshness from type queries#25471
weswigham merged 2 commits into
microsoft:masterfrom
weswigham:typeof-strips-freshness

Conversation

@weswigham
Copy link
Copy Markdown
Member

Fixes #25469.

With this change, type queries no longer propagate freshness.

@weswigham
Copy link
Copy Markdown
Member Author

weswigham commented Jul 5, 2018

I can confirm that this fixes the one new error in RWC we introduced with the lib change and otherwise affects no other RWC projects. (Also doesn't seem to affect user tests)

@@ -0,0 +1,56 @@
=== tests/cases/compiler/typeofStripsFeshness.ts ===
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo:freshness

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so fesh

@weswigham weswigham merged commit 547856a into microsoft:master Jul 6, 2018
@weswigham weswigham deleted the typeof-strips-freshness branch July 6, 2018 20:07
RyanCavanaugh added a commit to RyanCavanaugh/TypeScript that referenced this pull request Dec 2, 2022
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants