Optimize sourcemap application more#25425
Merged
weswigham merged 5 commits intoJul 5, 2018
Merged
Conversation
| const combinedPath = combinePaths(getDirectoryPath(node.sourceMapPath!), relativePath); | ||
| if (!resolvedPathCache.has(combinedPath)) { | ||
| resolvedPathCache.set(combinedPath, getRelativePathToDirectoryOrUrl( | ||
| if (!resolvedPathCache.has("" + raw.sourceIndex)) { |
Member
There was a problem hiding this comment.
Is caching the result of "" + raw.sourceIndex a worthwhile microoptimization?
Member
Author
There was a problem hiding this comment.
The VM is likely already doing that itself; but it would make the code a bit cleaner here, so I may do it for style.
RyanCavanaugh
approved these changes
Jul 5, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this, self-compilation time shifts much more into
onEmitNodeandemitBodyWithDetachedComments(as far as emit goes), and declaration diagnostics (typechecking) over the sourcemap emitter, from my observations.