factory: remove deprecated overloads#25350
Closed
ajafff wants to merge 1 commit into
Closed
Conversation
They have been deprecated for at least 9 months Unfortunately the comment was no JSDoc, therefore it was never deprecated in the generated declaration file.
Member
Contributor
Author
|
I've opened #25363 to deprecate them first using JSDoc. The actual removal can be done later |
Contributor
|
Looks like no use in tsickle or Google, delete away. |
Member
|
Okay, I think the plan will be to deprecate for 3.0, delete in 3.1. |
urish
added a commit
to mockdeep/typewiz
that referenced
this pull request
Jul 3, 2018
urish
added a commit
to mockdeep/typewiz
that referenced
this pull request
Jul 3, 2018
Collaborator
|
This PR doesn't have any linked issues. Please open an issue that references this PR. From there we can discuss and prioritise. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They have been deprecated for at least 9 months
Unfortunately the comment was no JSDoc, therefore it was never deprecated in the generated declaration file.