Skip to content

getLeftmostExpression: handle AsExpression and NonNullExpression#25342

Merged
DanielRosenwasser merged 3 commits into
microsoft:masterfrom
ajafff:factory-leftmost-expression
Jul 4, 2018
Merged

getLeftmostExpression: handle AsExpression and NonNullExpression#25342
DanielRosenwasser merged 3 commits into
microsoft:masterfrom
ajafff:factory-leftmost-expression

Conversation

@ajafff
Copy link
Copy Markdown
Contributor

@ajafff ajafff commented Jun 30, 2018

Fixes: #25223

@DanielRosenwasser
Copy link
Copy Markdown
Member

Great! Can you add the tests from your original issue to our src/unittests folder? I'd say it should probably be in transform.ts, but maybe it should be in printer.ts depending on the answer to #25223 (comment)

@ajafff
Copy link
Copy Markdown
Contributor Author

ajafff commented Jul 2, 2018

I added a new file src/testRunner/unittests/factory.ts as I will probably add more tests for factory functions while I fix the remaining issues.
Note that I used createArrowFunction for testing to avoid conflicts with #25348

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jul 3, 2018

@rbuckton can you please review and merge

@DanielRosenwasser DanielRosenwasser merged commit e4145e3 into microsoft:master Jul 4, 2018
@DanielRosenwasser
Copy link
Copy Markdown
Member

Thanks!

@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants