Skip to content

Typo#25313

Merged
mhegazy merged 11 commits into
microsoft:masterfrom
github-john-doe:typo
Jul 5, 2018
Merged

Typo#25313
mhegazy merged 11 commits into
microsoft:masterfrom
github-john-doe:typo

Conversation

@github-john-doe
Copy link
Copy Markdown
Contributor

No description provided.

@DanielRosenwasser
Copy link
Copy Markdown
Member

Can you make sure the respective input test files (from the .types/.symbols files) are also updated?

@github-john-doe
Copy link
Copy Markdown
Contributor Author

It looks like the test failures are related to a file named api/tsserverlibrary.d.ts that I didn't touch.
Can I have some idea how do I fix it?

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jun 29, 2018

Can I have some idea how do I fix it?

run the tests locally (jake runtests-parallel), then accept the changes to the baselines (jake baseline-accept) and include the new baselines in your PR (git add .).

@mhegazy mhegazy merged commit 8911c19 into microsoft:master Jul 5, 2018
@github-john-doe github-john-doe deleted the typo branch July 6, 2018 05:08
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants