Remove redundant checks in getNameOfDeclaration#25244
Merged
1 commit merged intoJun 27, 2018
Merged
Conversation
4411e5f to
da37958
Compare
da37958 to
677f320
Compare
sandersn
approved these changes
Jun 27, 2018
| let type = getLateBoundSymbol(prop).nameType; | ||
| if (!type && !isKnownSymbol(prop)) { | ||
| const name = getNameOfDeclaration(prop.valueDeclaration); | ||
| const name = prop.valueDeclaration && getNameOfDeclaration(prop.valueDeclaration); |
Member
There was a problem hiding this comment.
how did these work before? Is valueDeclaration's type incorrect?
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
if (!declaration)is redundant since the input type is declared non-optional.case SyntaxKind.JSDocCallbackTag:has the same behavior as just falling through to the bottom.