Don't crash on property access with type#25170
Merged
2 commits merged intoJun 25, 2018
Merged
Conversation
ee60c19 to
fb251bd
Compare
sandersn
requested changes
Jun 25, 2018
Member
sandersn
left a comment
There was a problem hiding this comment.
Looks good but need to rerevriw after force push.
| @@ -0,0 +1,12 @@ | |||
| error TS5055: Cannot write file '/a.js' because it would overwrite input file. | |||
Member
There was a problem hiding this comment.
noEmit: true will avoid this error
| @@ -0,0 +1,9 @@ | |||
| // @allowJs: true | |||
Member
There was a problem hiding this comment.
Can you please 1. Rename to jsdocPrototypePropertyAccessWithType 2. Move to conformance/jsdoc
sandersn
approved these changes
Jun 25, 2018
Member
sandersn
left a comment
There was a problem hiding this comment.
Just the one comment on moving the test
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #25154
#20198 added support for
/** @type {number} */ this.x;syntactically, but we were crashing in the checker if that syntax was used.This stops the crashing, but there is no error reporting yet (#25169).