Always preserve new lines for array and object literals.#2517
Closed
CyrusNajmabadi wants to merge 1 commit into
Closed
Always preserve new lines for array and object literals.#2517CyrusNajmabadi wants to merge 1 commit into
CyrusNajmabadi wants to merge 1 commit into
Conversation
Contributor
|
I like #2518 better, but I will also sign off on this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Regardless of the value of 'preserveNewLines'.
Fixes: #2513
An alternative approach would be do just remove the preserveNewLines flag, and attempt to preserve in all the other places we handle this today. That would be my preference. You can see this alternate approach here: #2518
This produces output closer to the original code, and means that you don't get ugly code explosion when you write nice single-lined stuff like arrow functions, and in many cases, you don't have your complex multi-line code smushed up to a singline line.
Thoughts?