Skip to content

Simplify getRangeOfEnclosingComment#25168

Merged
2 commits merged into
masterfrom
getRangeOfEnclosingComment
Jun 29, 2018
Merged

Simplify getRangeOfEnclosingComment#25168
2 commits merged into
masterfrom
getRangeOfEnclosingComment

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 23, 2018

  • Use find instead of manual loop.
  • No need to take onlyMultiLine and predicate as parameters; can just filter the result if needed.

@ghost ghost force-pushed the getRangeOfEnclosingComment branch 3 times, most recently from c71a3e3 to 2593348 Compare June 25, 2018 17:43
@ghost ghost requested a review from uniqueiniquity June 25, 2018 17:43
@ghost ghost force-pushed the getRangeOfEnclosingComment branch from 2593348 to 410c3d2 Compare June 26, 2018 20:24
Copy link
Copy Markdown
Contributor

@uniqueiniquity uniqueiniquity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ghost ghost merged commit e7543d6 into master Jun 29, 2018
@ghost ghost deleted the getRangeOfEnclosingComment branch June 29, 2018 23:58
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant