Parse nested prop and param tags the same way#25139
Merged
Merged
Conversation
That is, only nest them if their name matches the provided parent name. Otherwise do not nest them. Note that this commit changes the behaviour of an incorrect typedef that contains both an `@type` child tag and `@property` child tags. Previously, the `@type` would be incorrectly nested under a `@property` tag with type `object`, just like `@property` tags would be. Now, the `@type` tag causes the entire typedef to ignore the `@property` tags and treat the typedef as if it were an instance of the typedef-and-nested-type pattern: ```js /** * @typedef {Object} name * @type {{ the, actual, type }} */ ```
mhegazy
approved these changes
Jun 21, 2018
|
Thanks for the quick fix on that, keep up the good work guys! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That is, only nest them if their name matches the provided parent name. Otherwise do not nest them. Now this code creates a type with three properties
a,b,cinstead of twoa,b:Note that this commit changes the behaviour of an incorrect typedef that contains both an
@typechild tag and@propertychild tags.Previously, the
@typewould be incorrectly nested under a@propertytag with typeobject, just like@propertytags would be. Now, the@typetag causes the entire typedef to ignore the@propertytags and treat the typedef as if it were an instance of the typedef-and-nested-type pattern:Fixes #25072
Fixes #25118