In JS, always check the extends tag of a class before its heritage clause#25111
Merged
Conversation
Previously getBaseTypeNodeOfClass checked, but this is only used in a few places.
mhegazy
approved these changes
Jun 20, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously getBaseTypeNodeOfClass checked the extends tag of a class, but this is only used in a few places. Now (almost) everywhere that called getClassExtendsHeritageClauseElement now calls getEffectiveBaseTypeNode, which checks the extends tag and then the heritage clause. The exceptions are places that need to explicitly check the heritage clause.
Fixes #25101