Fixes downstream prepend projects not being built correctly on upstream changes#25049
Merged
Merged
Conversation
sandersn
approved these changes
Jun 18, 2018
| @@ -809,6 +810,7 @@ namespace ts { | |||
| // *after* those files, then we're "psuedo up to date" and eligible for a fast rebuild | |||
Member
Author
There was a problem hiding this comment.
I need a VS Code Extension just for this word
weswigham
approved these changes
Jun 18, 2018
Member
weswigham
left a comment
There was a problem hiding this comment.
Any way we can add a test for this codepath so we don't regress?
Member
Author
|
Yeah I need to suck it up and add an outFile/prepend suite. I'll do that now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes an issue @ahejlsberg found in our build
We will need a subsequent LKG update for local development