Skip to content

Fix bug: Still implement a method even if the return type is defined in another file#24978

Merged
1 commit merged into
masterfrom
nodebuilder_return
Jun 19, 2018
Merged

Fix bug: Still implement a method even if the return type is defined in another file#24978
1 commit merged into
masterfrom
nodebuilder_return

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Jun 15, 2018

Fixes #24977

@ghost ghost force-pushed the nodebuilder_return branch from 5971dcb to 21fc0fd Compare June 15, 2018 00:12
@ghost ghost requested a review from rbuckton June 15, 2018 00:12
@ghost ghost force-pushed the nodebuilder_return branch 3 times, most recently from 2e7be44 to 83f5f95 Compare June 15, 2018 17:34
@ghost ghost force-pushed the nodebuilder_return branch from 83f5f95 to dd13ef5 Compare June 15, 2018 17:38
@ScottMorris
Copy link
Copy Markdown

Thanks @Andy-MS for fixing this.

@ghost ghost force-pushed the nodebuilder_return branch from dd13ef5 to 41b1539 Compare June 15, 2018 21:30
@mhegazy mhegazy requested a review from weswigham June 19, 2018 23:00
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jun 19, 2018

@weswigham can you please review.

@ghost ghost merged commit b3f9ec3 into master Jun 19, 2018
@ghost ghost deleted the nodebuilder_return branch June 19, 2018 23:36
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants