🤖 User test baselines have changed#24952
Merged
Merged
Conversation
5cd0d86 to
190609a
Compare
sandersn
reviewed
Jun 14, 2018
| @@ -34,9 +34,9 @@ node_modules/chrome-devtools-frontend/front_end/Runtime.js(398,24): error TS8024 | |||
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(527,49): error TS2352: Type 'Window' cannot be converted to type 'Function'. | |||
| Property 'apply' is missing in type 'Window'. | |||
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(539,20): error TS2351: Cannot use 'new' with an expression whose type lacks a call or construct signature. | |||
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(693,7): error TS2322: Type 'Promise<boolean>' is not assignable to type 'Promise<undefined>'. | |||
| node_modules/chrome-devtools-frontend/front_end/Runtime.js(693,7): error TS2322: Type 'Promise<boolean>' is not assignable to type 'Promise<undefined>'. | |||
Member
There was a problem hiding this comment.
looks like we still have some duplicate errors. Fix is up at #24508
sandersn
approved these changes
Jun 14, 2018
| lib/ElementHandle.js(83,29): error TS2503: Cannot find namespace 'Protocol'. | ||
| lib/EmulationManager.js(36,16): error TS2503: Cannot find namespace 'Protocol'. | ||
| lib/ExecutionContext.js(22,15): error TS2503: Cannot find namespace 'Protocol'. | ||
| lib/ExecutionContext.js(87,15): error TS2304: Cannot find name 'Frame'. |
Member
There was a problem hiding this comment.
this error occurs because we now support @this.
| @@ -3245,8 +3245,11 @@ node_modules/chrome-devtools-frontend/front_end/bindings/ResourceScriptMapping.j | |||
| node_modules/chrome-devtools-frontend/front_end/bindings/ResourceScriptMapping.js(298,22): error TS2694: Namespace 'Common' has no exported member 'Event'. | |||
| node_modules/chrome-devtools-frontend/front_end/bindings/ResourceScriptMapping.js(305,22): error TS2694: Namespace 'Common' has no exported member 'Event'. | |||
| node_modules/chrome-devtools-frontend/front_end/bindings/ResourceScriptMapping.js(318,26): error TS2694: Namespace 'Protocol' has no exported member 'Runtime'. | |||
| node_modules/chrome-devtools-frontend/front_end/bindings/ResourceScriptMapping.js(323,14): error TS2339: Property '_scriptSource' does not exist on type 'ResourceScriptFile'. | |||
Member
There was a problem hiding this comment.
this is now typed, but we can't resolve the properties on the type (it may be incorrect).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please review the diff and merge if no changes are unexpected.
You can view the build log here.
cc @weswigham @sandersn @mhegazy