Fix API Sample tests#24911
Merged
Merged
Conversation
Member
|
Reminder: Those nested namespaces are |
weswigham
reviewed
Jun 12, 2018
| @@ -139,11 +139,6 @@ compileOutputConfigFile('src/typescriptServices/tsconfig.json', [], [copyright], | |||
| // Created by appending 'export = ts;' at the end of the standalone file to turn it into an external module | |||
| var nodeDefinitionsFileContents = definitionFileContents + "\nexport = ts;"; | |||
Member
There was a problem hiding this comment.
To support browser cases seamlessly, this should also probably append "\nexport as namespace ts;" now.
Contributor
Author
There was a problem hiding this comment.
I can get these done in a different PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were generating typescript_standalone.d.ts by converting
namespace tstomodule "typescript"that seems to be broken with nested namespaces. instead of trying to fix the regexp, i have switched to use thetypescriptservcies.d.tsAlso removing the generation portion from jake.