Add full format options to configure request and remove ability from open request#2489
Closed
dbaeumer wants to merge 2 commits into
Closed
Add full format options to configure request and remove ability from open request#2489dbaeumer wants to merge 2 commits into
dbaeumer wants to merge 2 commits into
Conversation
|
Hi @dbaeumer, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
Contributor
|
👍 |
Contributor
|
thanks |
Contributor
|
👍 |
dbaeumer
added a commit
that referenced
this pull request
Mar 26, 2015
Member
Author
|
Merged pull request into master. |
Member
Author
|
Although stated different by github I merged it over. I merged on my local machine. Had quite some conflicts. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow up pull request from #2468. I followed @steveluc suggestion:
So my vote is just provide formatting options on configure, even removing them from open, because the editor may know that the server’s defaults are correct and because the editor may decide to send a configuration message for each file immediately after the open message.
I started a new pull request since the new one doesn't have much in common with the old one. I closed the old one.