Simplify tryDeleteDeclaration#24808
Merged
1 commit merged intoJun 11, 2018
Merged
Conversation
4bf9ff1 to
8e05458
Compare
mhegazy
approved these changes
Jun 11, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
token.kindis alwaysIdentifier,StringLiteralorNumberLiteral. Thecase SyntaxKind.PropertyDeclaration:andcase SyntaxKind.NamespaceImport:cases were thus dead code. Those aren't token kinds, so theoretically we could have caught this by having a type for tokens.Simplified the code by going into
tryDeleteIdentifierdirectly;tryDeleteDefaultis now only called in one place and makes sense to inline.