Add signature help to Typescript server#2480
Conversation
|
Hi @dbaeumer, I'm your friendly neighborhood Microsoft Pull Request Bot (You can call me MSBOT). Thanks for your contribution!
TTYL, MSBOT; |
There was a problem hiding this comment.
Add a space after the colon
|
Hey @dbaeumer, For details on applicable spans, see the applicable span calculation for call expressions and for tagged templates. |
There was a problem hiding this comment.
You guys seem to do something similar throughout the function, you might want to consider just making a helper that returns a {start: number, end: number}.
|
Apart from the nit about the space after the colon, this looks good to me. I'll let @steveluc give the 👍 though. |
|
This is great. Thanks. Could you consider changing the name to SignatureHelpParameter to SignatureHelpArgs. The rest are named with the Args suffix. |
|
Disregard previous comment. I see the naming is consistent and SignatureHelpParameter is part of the response. 👍 |
There was a problem hiding this comment.
Put the comment on the wrong PR. so putting it here again :)
Can you also update client.ts and add a test for signature help in tests\cases\fourslash\server. I would copy a signature help test from tests\cases\fourslash to start.
|
Thanks for all the comments. Will work on the test and fix the typos and provide an updated. pull request. |
|
👍 |
Add signature help to Typescript server
Enclosed a pull request to add signature help support to the TypeScript server. I tried to follow the style I found in the existing code (e.g. expose the language service API, no extra abstraction).
There is one thing I left open: I don't know the meaning of applicableSpan in SignatureHelpItems. Can someone of you fill in the comment.
Thanks Dirk