Add completions from literal contextual types#24674
Merged
3 commits merged intoJun 7, 2018
Merged
Conversation
ed58a9d to
18f6953
Compare
18f6953 to
e46d214
Compare
sheetalkamat
reviewed
Jun 7, 2018
| node.getEnd() <= textSpanEnd(span); | ||
| } | ||
|
|
||
| export function getTypesOfUnion(type: Type): ReadonlyArray<Type> { |
Member
There was a problem hiding this comment.
I think we need better name as the name suggests that it handles only union.
Member
There was a problem hiding this comment.
Also this creates unnecessary array for the non union type. Depending on how frequently this would be called, that's too many arrays for no reason?
mhegazy
reviewed
Jun 7, 2018
| if (type.flags & TypeFlags.String) { | ||
| return createLiteral(""); | ||
| } | ||
| else if (type.flags & TypeFlags.Number) { |
Contributor
There was a problem hiding this comment.
not sure about string and number.. the possible values here are infinite, any thing we suggest will likely be wrong.
7e250da to
baba716
Compare
baba716 to
581e350
Compare
mhegazy
approved these changes
Jun 7, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16863