Support 'tsconfig.json' when converting TextChanges to CodeEdits#24667
Merged
2 commits merged intoJun 7, 2018
Merged
Conversation
4609f30 to
f29469b
Compare
mhegazy
reviewed
Jun 6, 2018
|
|
||
| function getSourceFileByPath(path: Path): SourceFile | undefined { | ||
| return filesByName.get(path); | ||
| return options.configFile && toPath(options.configFile.fileName) === path ? options.configFile : filesByName.get(path); |
Contributor
There was a problem hiding this comment.
Can we do this on the project level instead in the program? it just feels wrong to have program return a sourceFile that is not part of it.
Contributor
There was a problem hiding this comment.
maybe we should create a new method on Project to getSourceFileOrConfigFile and use that instead.
sheetalkamat
approved these changes
Jun 7, 2018
mhegazy
approved these changes
Jun 7, 2018
Contributor
|
Please port to release-2.9 as well. |
ghost
pushed a commit
that referenced
this pull request
Jun 7, 2018
) (#24772) * Support 'tsconfig.json' when converting TextChanges to CodeEdits * Create Project#getSourceFileOrConfigFile to use instead
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #24613
Note: the bug I'm fixing reproduces even given only one project, but I'm pretty sure that the original cause of the issue was that the extra project had
"files"in its tsconfig, so that was updated.