Skip to content

Visit the children of an import type/require call/dynamic import when looking for those#24663

Merged
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:visit-dynamic-import-children
Jun 4, 2018
Merged

Visit the children of an import type/require call/dynamic import when looking for those#24663
weswigham merged 1 commit into
microsoft:masterfrom
weswigham:visit-dynamic-import-children

Conversation

@weswigham
Copy link
Copy Markdown
Member

@weswigham weswigham commented Jun 4, 2018

Fixes #24562

This way nested import types are found, eg import("").A<import("")> or require<import("")>("").

@weswigham weswigham requested a review from mhegazy June 4, 2018 19:57
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jun 4, 2018

let's port this to release-2.9 as well.

@weswigham weswigham merged commit 7eaa788 into microsoft:master Jun 4, 2018
@weswigham weswigham deleted the visit-dynamic-import-children branch June 4, 2018 21:32
weswigham added a commit to weswigham/TypeScript that referenced this pull request Jun 4, 2018
weswigham added a commit that referenced this pull request Jun 5, 2018
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants