allow access protected member in this parameter context#24645
Merged
Conversation
mhegazy
reviewed
Jun 4, 2018
| return false; | ||
| let thisParameter: ParameterDeclaration | undefined; | ||
| const thisContainer = getThisContainer(node, /* includeArrowFunctions */ false); | ||
| if (!thisContainer || !isFunctionLike(thisContainer) || !(thisParameter = getThisParameter(thisContainer)) || !thisParameter.type) { |
Contributor
There was a problem hiding this comment.
it is kind of weird that this works for static properties without this.. i think we should prohibit this. e.g.:
class C {
protected static S = 0;
}
C.S; // Error
function f(this: C) {
C.S; // OK
}
Contributor
|
@weswigham can you please review this change. |
mhegazy
reviewed
Jun 7, 2018
| // static member access is disallow | ||
| let thisParameter: ParameterDeclaration | undefined; | ||
| const thisContainer = getThisContainer(node, /* includeArrowFunctions */ false); | ||
| if (flags & ModifierFlags.Static || !thisContainer || !isFunctionLike(thisContainer) || !(thisParameter = getThisParameter(thisContainer)) || !thisParameter.type) { |
Contributor
There was a problem hiding this comment.
nit. i would move the check for the flag above the request for getThisContainer
weswigham
approved these changes
Jun 11, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this PR take a simple implement
ThisParameterwhen cannot findenclosingClassin protected accessibility checkConstraintif typeof this is generic parameterFixes #10302