Treat host as possibly undefined for base64encode/base64decode#24641
Merged
mhegazy merged 1 commit intoJun 4, 2018
Conversation
3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #24638
Does not assume that
ts.sys(a.k.a.host) is always defined, because when running on non-node/ChakraCore runtimes (e.g. deno),.sysdoes not get defined currently.Here's a checklist you might find useful.
'Bug' or 'help wanted' or is in the Community milestone
masterbranchjake runtestsgulp runtestslocallyFixes: #24638
Refs: ry/deno#117
[1]: I couldn't find any unit tests that were appropriate to update or add for this area of code. Would be glad to if someone could point out a related unit test.