Document highlights on yield keywords highlight other occurrences in …#24431
Merged
Conversation
ghost
approved these changes
May 30, 2018
|
|
||
| verify.rangesAreOccurrences(false); | ||
|
|
||
| goTo.marker(); |
There was a problem hiding this comment.
Don't think the rest of the test is necessary -- verify.rangesAreOccurrences should already loop over all ranges and test that all the other ranges are document highlights of it. See verifyRangesAreOccurrences in fourslash.ts.
Contributor
Author
There was a problem hiding this comment.
I saw this pattern in many fourslash tests so I just copy & paste it. Maybe we should remove these redundant/misleading code.
Contributor
|
@Zzzen can you merge master into your branch again to get the tests to pass. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…the same body
See #23923 (comment)