Disallow nested object param syntax in callback tag#24392
Merged
Conversation
Previously this caused a crash in parsing. If/when we want to support this syntax, we will need to fix this crash.
mhegazy
approved these changes
May 24, 2018
Contributor
|
Please port to release-2.9 as well. |
sandersn
added a commit
that referenced
this pull request
May 24, 2018
* Callback tag:Disallow nested-object-param syntax Previously this caused a crash in parsing. If/when we want to support this syntax, we will need to fix this crash. * Update baselines
Member
Author
|
OK, it's it 2.9 now as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously this caused a crash in parsing. If/when we want to support this syntax, we will need to fix this crash. For now, it's enough to skip the code path and continue parsing in a non-nested fashion.
Fixes #24389