Fix to issue 23326 for completions on new.target#24342
Merged
Merged
Conversation
|
|
RyanCavanaugh
previously requested changes
May 22, 2018
| case SyntaxKind.ImportType: | ||
| node = parent; | ||
| break; | ||
| case SyntaxKind.MetaProperty: |
Member
There was a problem hiding this comment.
Move two lines up and delete duplicate code
| ////} | ||
|
|
||
| goTo.marker(""); | ||
| debugger; |
Member
There was a problem hiding this comment.
Remove debugger statement
…code in switch statement for completions
mhegazy
reviewed
May 23, 2018
| } | ||
| } | ||
|
|
||
| if (isMetaProperty(node) && node.keywordToken === SyntaxKind.NewKeyword) { |
Contributor
There was a problem hiding this comment.
import.meta is another meta property that we should support.
sheetalkamat
approved these changes
May 23, 2018
RyanCavanaugh
approved these changes
May 23, 2018
Member
|
(thought I had a suggestion but I didn't) |
mhegazy
approved these changes
May 23, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23326