Skip to content

Fix issue with formatting object literal csharp style#24262

Merged
armanio123 merged 3 commits into
microsoft:masterfrom
armanio123:FixObjectLiteralExpression
May 22, 2018
Merged

Fix issue with formatting object literal csharp style#24262
armanio123 merged 3 commits into
microsoft:masterfrom
armanio123:FixObjectLiteralExpression

Conversation

@armanio123
Copy link
Copy Markdown
Contributor

@armanio123 armanio123 commented May 18, 2018

Fixes feedback: https://developercommunity.visualstudio.com/content/problem/253676/js-and-ts-indentation-issue.html.

Current formatting:

var clear =
    {
        outerKey:
            {
                innerKey: 1
            }
    };

Expected formatting:

var clear =
{
    outerKey:
    {
        innerKey: 1
    }
};

@armanio123 armanio123 requested review from a user, billti and mhegazy May 18, 2018 23:39
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented May 19, 2018

How this different from #22849, and why is the fix in #22849 not sufficient?

i see it working for me locally...

screen

@armanio123
Copy link
Copy Markdown
Contributor Author

armanio123 commented May 21, 2018

This is for fixing it during typing.

Before this fix:
before

After this fix:
after

mhegazy
mhegazy approved these changes May 21, 2018
View reviewed changes
Copy link
Copy Markdown
Contributor

@mhegazy mhegazy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test

@armanio123 armanio123 merged commit b5d882e into microsoft:master May 22, 2018
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented May 22, 2018

@armanio123 please port to release-2.9

@armanio123 armanio123 mentioned this pull request May 22, 2018
Merged
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@billti billti Awaiting requested review from billti

2 more reviewers

@mhegazy mhegazy mhegazy approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@armanio123 @mhegazy