Unused variable error reporting needs to handle nodes that could not belong to current source file#24234
Merged
Merged
Conversation
…belong to current source file Eg. when resolving module, the another file gets checked and its locals are added to potentiallyUnused list Fixes #24215
mhegazy
approved these changes
May 18, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When checking the sourceFile, if we encounter module import and its not yet resolved, it would go and resolve its type, resulting in checking locals of the module (which is different file than the file thats being checked. So we need to add the potentialUnused node to correct source file list.
Fixes #24215