Remove leveldown, stip absolute paths from test mk 2, accept reordered and new user baselines#24227
Conversation
…d and new user baselines
sandersn
left a comment
There was a problem hiding this comment.
Looks OK, although changes in chrome-devtools-frontend points out two new bugs in type parameter lookup. I'll add links after I file them.
| node_modules/chrome-devtools-frontend/front_end/externs.js(82,13): error TS2355: A function whose declared type is neither 'void' nor 'any' must return a value. | ||
| node_modules/chrome-devtools-frontend/front_end/externs.js(86,17): error TS2339: Property 'rotate' does not exist on type 'any[]'. | ||
| node_modules/chrome-devtools-frontend/front_end/externs.js(90,17): error TS2339: Property 'sortNumbers' does not exist on type 'any[]'. | ||
| node_modules/chrome-devtools-frontend/front_end/externs.js(92,13): error TS2304: Cannot find name 'S'. |
There was a problem hiding this comment.
That's interesting. These are new? Oh wait. Does this include changes from chrome-devtools-frontend, or is it pinned?
There was a problem hiding this comment.
Pretty sure it's pinned.
There was a problem hiding this comment.
This is the location of the error, ish:
There was a problem hiding this comment.
Looks like @template on generic methods is borked.
| node_modules/chrome-devtools-frontend/front_end/platform/utilities.js(1169,24): error TS2304: Cannot find name 'KEY'. | ||
| node_modules/chrome-devtools-frontend/front_end/platform/utilities.js(1169,30): error TS2304: Cannot find name 'VALUE'. | ||
| node_modules/chrome-devtools-frontend/front_end/platform/utilities.js(1171,15): error TS2339: Property 'inverse' does not exist on type 'Map<any, any>'. | ||
| node_modules/chrome-devtools-frontend/front_end/platform/utilities.js(1191,14): error TS2304: Cannot find name 'K'. |
There was a problem hiding this comment.
Also templates - this time templates for prototype methods not having the templates declared for the constructor (though they should).
There was a problem hiding this comment.
Yep, looks like the check I put in resolveEntityName needs to understand prototype assignments in addition to the prototype method assignments it already does.
This is all our recent user test changes, along with a small patch to remove the absolute path from the baseline, and the reordering I still hadn't accepted baselines for.