🤖 User test baselines have changed#24100
Conversation
|
|
| src/cli/util.js(335,52): error TS2339: Property 'length' does not exist on type 'Ignore'. | ||
| src/cli/util.js(396,46): error TS2345: Argument of type 'null' is not assignable to parameter of type 'number | undefined'. | ||
| src/cli/util.js(403,39): error TS2339: Property 'grey' does not exist on type 'typeof import("E:/Github/TypeScript/node_modules/chalk/types/index")'. | ||
| src/cli/util.js(403,39): error TS2339: Property 'grey' does not exist on type 'typeof import("/opt/vsts/work/1/s/node_modules/chalk/types/index")'. |
There was a problem hiding this comment.
My RE filtering out platform paths doesn't hit this line because this is an error referencing a path in our node_modules folder and not the test's; that implies this types: [] alone isn't good enough... (since our @types/chalk is still overriding the local chalk). Methinks we need to add a typeRoots to these tests, to disable the module folder walk.
| lib/Page.js(394,22): error TS2503: Cannot find namespace 'Protocol'. | ||
| lib/Page.js(407,15): error TS2503: Cannot find namespace 'Protocol'. | ||
| lib/Page.js(731,19): error TS2503: Cannot find namespace 'Protocol'. | ||
| lib/externs.d.ts(2,30): error TS2497: Module '"/puppeteer/puppeteer/lib/Browser"' resolves to a non-module entity and cannot be imported using this construct. |
There was a problem hiding this comment.
these just moved around.. looks like we are sorting using case insensitive paths..
There was a problem hiding this comment.
Platform case, because we're shelling out to tsc. I may just resort the errors in the test runner.
|
The desirable changes are now in #24115 (which does include reordering the diagnostics in a case-sensitive way). Thanks for the help @typescript-bot 😆 |
Please review the diff and merge if no changes are unexpected.
cc @weswigham @sandersn @mhegazy