Skip to content

Don't count '/' in division as a completions trigger#24038

Merged
1 commit merged into
masterfrom
completionsTriggerCharacter_slash
May 10, 2018
Merged

Don't count '/' in division as a completions trigger#24038
1 commit merged into
masterfrom
completionsTriggerCharacter_slash

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented May 10, 2018

@mjbvz Currently vscode doesn't seem to trigger at all on '/', but maybe it should as in <div> foo </ completing with div.

@ghost ghost requested a review from sheetalkamat May 10, 2018 21:44
@ghost ghost merged commit 61a2949 into master May 10, 2018
@ghost ghost deleted the completionsTriggerCharacter_slash branch May 10, 2018 21:59
@mjbvz
Copy link
Copy Markdown
Contributor

mjbvz commented May 10, 2018

Thanks. We have logic that only treats / as a trigger character if it looks like we are in an import path. I'll remove that

@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants