Skip to content

Add script for automatically creating PRs for user test updates#24036

Merged
weswigham merged 2 commits into
microsoft:masterfrom
weswigham:auto-user-PRs
May 10, 2018
Merged

Add script for automatically creating PRs for user test updates#24036
weswigham merged 2 commits into
microsoft:masterfrom
weswigham:auto-user-PRs

Conversation

@weswigham
Copy link
Copy Markdown
Member

The idea being that when the daily user tests fail on VSTS, it can run this script and automatically open a PR wih the changes.

@RyanCavanaugh Should I make a new bot account for this (to keep credential reuse low), or should we reuse one of the other bots?

@RyanCavanaugh
Copy link
Copy Markdown
Member

Cute. We can spin a new token for the bot

@weswigham
Copy link
Copy Markdown
Member Author

@RyanCavanaugh important question: does the bot have write permissions for the Microsoft/TypeScript repo? The GH API limits programmatic PR creation to tokens with write access to the target repo.

@weswigham weswigham merged commit 2dd0ff3 into microsoft:master May 10, 2018
@weswigham weswigham deleted the auto-user-PRs branch May 10, 2018 22:02
@RyanCavanaugh
Copy link
Copy Markdown
Member

@weswigham it should - if not, we can add it

@weswigham
Copy link
Copy Markdown
Member Author

I think it does; when I was logged in with it I checked the webui, and it had the option to commit directly to master, so I think we're 👌

@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants