Add createRegularExpressionLiteral and expose createStringLiteral#24000
Merged
Conversation
paranoidjk
reviewed
May 10, 2018
| return node; | ||
| } | ||
|
|
||
| export function createRegularExpressionLiteral(text: string): RegularExpressionLiteral { |
There was a problem hiding this comment.
👍 no need to add unit test for this?
Contributor
Author
There was a problem hiding this comment.
there are no unit tests for the other factory functions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #23992
I also wanted to add it to the convenience function
createLiteral:Unfortunately that's not possible because RegExp#flags was introduced in ES2015.
Is there a reason the TypeScript compiler doesn't use
lib: ["ES2015"]? It already declares ES2015 interfaces likeMapandIterator.