Fix crash in recursive declared type resolution#23950
Merged
Merged
Conversation
When one type has a type parameter with a default
mhegazy
approved these changes
May 9, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... when one type has a type parameter with a default.
This occurs because declaredCallSignatures and declaredConstructSignatures are undefined before getSignaturesOfSymbol returns, which can be observed if these properties are read during the execution of getSignaturesOfSymbol. This happens with the following example, which has mutually recursive interfaces, one of which has a type parameter with a default.
The simplest fix for the above program is to check whether we are in a javascript file immediately in fillMissingTypeArguments. But this doesn't work when the type alias is in a Javascript file (as shown in the test case for this PR), and in any case the recursive type resolution might fail in other ways in the future.
Fixes #23025