Skip to content

Update issue templates#23866

Merged
RyanCavanaugh merged 3 commits into
masterfrom
issue-templates
May 3, 2018
Merged

Update issue templates#23866
RyanCavanaugh merged 3 commits into
masterfrom
issue-templates

Conversation

@RyanCavanaugh
Copy link
Copy Markdown
Member

No description provided.

Comment thread .github/ISSUE_TEMPLATE/Bug_report.md Outdated

<!-- 🚨 STOP 🚨 𝗦𝗧𝗢𝗣 🚨 𝑺𝑻𝑶𝑷 🚨

Half of all issues filed here are duplicates, answered in the FAQ, or not appropriate for the bug tracker. Even if you think you've found a *bug*, please read the FAQ first, especially the Common "Bugs" That Aren't Bugs" section!
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Common "Bugs" That Aren't Bugs"

One too many " here.


**Actual behavior:**

**Playground Link:** <!-- A link to a TypeScript Playground "Share" link which demonstrates this behavior -->
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should include an actual link to an empty playground rather than referencing "a TypeScript Playground".

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People seem to be doing a good job filling this in; I'm concerned that if we add in a literal link to the TypeScript playground, they'll think they don't have to do anything extra.


## Checklist

I attest that all of the following are true:
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is a bit formal. why not drop the I attest part. they created the issue, so i am assuming the declaration is implied.

[ ] This wouldn't change the behavior of existing JavaScript code
[ ] This could be implemented without emitting different JS based on the types of the expressions
[ ] This isn't a runtime feature that should be handled by TC39 instead
[ ] This wouldn't be a breaking change in existing TypeScript / JavaScript code
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think the breakinc change should come in on top

I attest that all of the following are true:
[ ] This wouldn't change the behavior of existing JavaScript code
[ ] This could be implemented without emitting different JS based on the types of the expressions
[ ] This isn't a runtime feature that should be handled by TC39 instead
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"should be handled by TC39" is a bit subjective. i would make it does this introduce any new syntax

## Checklist

I attest that all of the following are true:
[ ] This wouldn't change the behavior of existing JavaScript code
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is a bit vague.. and how is different from the below two points? and why is the first?

@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented May 3, 2018

yaaaay! it is happening!!

giphy

@RyanCavanaugh RyanCavanaugh merged commit 199ed98 into master May 3, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
@RyanCavanaugh RyanCavanaugh deleted the issue-templates branch June 16, 2022 22:08
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants