Pre-generate names ahead of time#23834
Merged
Merged
Conversation
weswigham
approved these changes
May 2, 2018
Member
weswigham
left a comment
There was a problem hiding this comment.
I like the side effect that the var declarations are in order now (even if the initial uses can now be out-of-order).
mhegazy
approved these changes
May 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change ensures that we pre-generate all names in a lexical scope before descending the tree. This allows us to ensure that generated names that must be preserved in nested scopes are allocated at the right time before traversing the tree. In addition to allowing us to remove the
SkipNameGenerationScopeflag for generated identifiers, this sets up some other future PRs that will need name generation to occur at an earlier time.For most of our performance suite the performance cost is not statistically significant. However, there is a very small increase in emit time (over one second) for very large projects (though still not statistically significant compared to an average emit time of over one minute).