Skip to content

Downlevel destructuring in module transformer if destructured variable has multiple names#23832

Merged
weswigham merged 2 commits into
microsoft:masterfrom
weswigham:downlevel-exported-destructuring
May 2, 2018
Merged

Downlevel destructuring in module transformer if destructured variable has multiple names#23832
weswigham merged 2 commits into
microsoft:masterfrom
weswigham:downlevel-exported-destructuring

Conversation

@weswigham
Copy link
Copy Markdown
Member

Fixes #23804

@weswigham weswigham requested review from a user, mhegazy and rbuckton May 2, 2018 20:44
Copy link
Copy Markdown
Contributor

@rbuckton rbuckton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor formatting nit.

noSubstitution[getNodeId(expression)] = true;
expression = createExportExpression(exportName, expression, /*location*/ node);
}
const exportedNames = getExports(node.left);
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The indentation here is incorrect.

@weswigham weswigham merged commit 9c40d27 into microsoft:master May 2, 2018
@weswigham weswigham deleted the downlevel-exported-destructuring branch May 2, 2018 23:20
@microsoft microsoft locked and limited conversation to collaborators Jul 31, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants