The node builder should strive to preserve mapped type keyof-ness#23815
Merged
weswigham merged 1 commit intoMay 3, 2018
Conversation
mhegazy
approved these changes
May 3, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23583
getIndexTypedistributes over the intersection withinPartialPropertiesin the example in the linked issue and simplifies one branch to a literal. InresolveMappedTypeMembers, we already have something known as the "modifiersType" that is used to work around this and similar problems (when calculating optionality and readonly-ness), so now we use that in the node builder when we want to try and preserve keyof-ness there, too.