Skip to content

resolveEntityName: don't return false#23563

Merged
sandersn merged 1 commit into
microsoft:masterfrom
ajafff:resolveEnitityName-false
Apr 20, 2018
Merged

resolveEntityName: don't return false#23563
sandersn merged 1 commit into
microsoft:masterfrom
ajafff:resolveEnitityName-false

Conversation

@ajafff
Copy link
Copy Markdown
Contributor

@ajafff ajafff commented Apr 20, 2018

Fixes: #23562
This was a regression introduced in #23511 /cc @sandersn

I don't know how to test this...

@sandersn
Copy link
Copy Markdown
Member

We don't really have tests for API values, just types, and in this case the type is wrong. @Andy-MS points out that his PR #22088 that enables strict null checks would have made the compiler catch this.

@sandersn sandersn merged commit f57ba59 into microsoft:master Apr 20, 2018
@microsoft microsoft locked and limited conversation to collaborators Jul 30, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants