findAllReferences: Reduce node.getSourceFile() calls#23524
Merged
2 commits merged intoApr 18, 2018
Merged
Conversation
| const sourceFile = node.getSourceFile(); | ||
| const textSpan = getTextSpan(isComputedPropertyName(node) ? node.expression : node, sourceFile); | ||
| return { containerKind: ScriptElementKind.unknown, containerName: "", fileName: sourceFile.fileName, kind, name, textSpan, displayParts }; | ||
| return { containerKind: ScriptElementKind.unknown, containerName: "", kind, name, displayParts, ...getTextSpanAndFileName(isComputedPropertyName(node) ? node.expression : node) }; |
Member
There was a problem hiding this comment.
Using this helper means we are creating unnecessary object and throwing it rightaway. Given that this is called in so many places, i would rather have it inlined than create this indirection.
sheetalkamat
approved these changes
Apr 18, 2018
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were recomputing the source file in a lot of places, this should ensure that we reuse the result.