Add implicit any errors for destructuring computed names which aren't late bound and have no corresponding index#23489
Merged
Conversation
…late bound and have no corresponding index
mhegazy
reviewed
Apr 17, 2018
| if (isTypeAssignableToKind(exprType, TypeFlags.NumberLike)) { | ||
| indexerType = getIndexTypeOfType(parentType, IndexKind.Number); | ||
| } | ||
| else if (isTypeAssignableToKind(exprType, TypeFlags.StringLike)) { |
Contributor
There was a problem hiding this comment.
string is valid for number indexing as well.. so symbols aside..
indexrType = (isTypeAssignableToKind(exprType, TypeFlags.NumberLike) && getIndexTypeOfType(parentType, IndexKind.Number) || getIndexTypeOfType(parentType, IndexKind.String)
e78530c to
d965c33
Compare
mhegazy
reviewed
Apr 17, 2018
| if (isTypeAssignableToKind(exprType, TypeFlags.NumberLike)) { | ||
| indexerType = getIndexTypeOfType(parentType, IndexKind.Number) || getIndexTypeOfType(parentType, IndexKind.String); | ||
| } | ||
| else if (isTypeAssignableToKind(exprType, TypeFlags.StringLike)) { |
Contributor
There was a problem hiding this comment.
const named = Symbol("");
let { [named]: prop } = strIndexed;
void prop;``today that is string ... we probably wanna keep it this way until we have a symbol indexer.
Member
Author
|
@mhegazy updated. Destructuring now has the same buggy behavior as indexing 😿 |
mhegazy
approved these changes
Apr 26, 2018
Contributor
|
We need to update it to handle symbols like we do in regular indexing. |
Member
Author
|
@mhegazy Does this look like the correct errors to issue for symbol destructuring (and should they be noImplicitAny)? |
mhegazy
approved these changes
Apr 27, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23334