goToDefinition: Reduce duplicate code around createDefinitionInfo#23473
Merged
3 commits merged intoApr 17, 2018
Merged
Conversation
mhegazy
reviewed
Apr 17, 2018
| const shorthandContainerName = typeChecker.symbolToString(symbol.parent, node); | ||
| return map(shorthandDeclarations, | ||
| declaration => createDefinitionInfo(declaration, shorthandSymbolKind, shorthandSymbolName, shorthandContainerName)); | ||
| return shorthandSymbol ? shorthandSymbol.declarations.map(decl => createDefinitionInfo(decl, typeChecker, shorthandSymbol, node)) : emptyArray; |
Contributor
There was a problem hiding this comment.
if you are using emptyArray the return type should be ReadonlyArray to avoid messing up the whole system when emptyArray is not empty.. I think emptyArray should be types as ReadOnlyArray<any> but that would be a separate change and potentially a big one.
mhegazy
approved these changes
Apr 17, 2018
added 2 commits
April 17, 2018 10:49
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
getSymbolInfois only ever sent tocreateDefinitionInfo-- so just compute it there.findinfindReferenceInPosition.