Shrink span for convert-to-es6-module suggestion#23441
Merged
1 commit merged intoApr 16, 2018
Merged
Conversation
amcasey
approved these changes
Apr 16, 2018
Member
amcasey
left a comment
There was a problem hiding this comment.
Did it used to be large because it was convenient when it was a refactoring? Or was it just an oversight?
| // @Filename: /a.js | ||
| ////[|exports.f = function() {}|]; | ||
| ////[|exports.f|] = function() {}; | ||
| ////exports.C = class {}; |
Member
There was a problem hiding this comment.
Do we only offer the fix on the first one?
Author
There was a problem hiding this comment.
Yes, only at the single location that comes from commonJsModuleIndicator.
Author
|
When it was a refactoring we used completely different code, since we started with a range and had to determine whether it was highlighting a commonjs-y thing. Now we are walking through the source file and adding suggestion diagnostics. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #23272