Switch webpack to submodule#23372
Merged
Merged
Conversation
I'm sure this will work with no problems!
The other submodules do this, although I'm not sure why.
Member
Author
|
I'm not sure why Travis fails. It says "can't fetch .travis.yml from github", which doesn't seem related. @weswigham any ideas? |
Member
|
No idea. Googling the issue seems to indicate that pushing a new commit may fix the issue. |
DanielRosenwasser
approved these changes
Apr 12, 2018
mhegazy
approved these changes
Apr 12, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Now that webpack builds with typescript.