Skip to content

improve parser and error message if definite assignment assertions in…#23253

Merged
RyanCavanaugh merged 2 commits into
microsoft:masterfrom
Kingwl:definite-assignment-assertion-improve
Sep 5, 2018
Merged

improve parser and error message if definite assignment assertions in…#23253
RyanCavanaugh merged 2 commits into
microsoft:masterfrom
Kingwl:definite-assignment-assertion-improve

Conversation

@Kingwl
Copy link
Copy Markdown
Contributor

@Kingwl Kingwl commented Apr 8, 2018

… object short hand

Fixes #23118

@Kingwl Kingwl force-pushed the definite-assignment-assertion-improve branch from 57d9965 to dc78c4f Compare April 8, 2018 10:03
Copy link
Copy Markdown
Member

@DanielRosenwasser DanielRosenwasser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're on 🔥 @Kingwl

@typescript-bot
Copy link
Copy Markdown
Collaborator

Thanks for your contribution. This PR has not been updated in a while and cannot be automatically merged at the time being. For housekeeping purposes we are closing stale PRs. If you'd still like to continue working on this PR, please leave a message and one of the maintainers can reopen it.

@Kingwl
Copy link
Copy Markdown
Contributor Author

Kingwl commented Jul 26, 2018

Up

@mhegazy mhegazy reopened this Jul 26, 2018
@mhegazy
Copy link
Copy Markdown
Contributor

mhegazy commented Jul 26, 2018

@Kingwl can you please refresh the PR?

@Kingwl
Copy link
Copy Markdown
Contributor Author

Kingwl commented Jul 26, 2018

wait for a few hours

@RyanCavanaugh RyanCavanaugh merged commit 5d65e86 into microsoft:master Sep 5, 2018
@Kingwl Kingwl deleted the definite-assignment-assertion-improve branch September 5, 2018 23:46
@microsoft microsoft locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants