Skip to content

findAllReferences: forEachRelatedSymbol can always include shorthand destructuring#23223

Merged
2 commits merged into
masterfrom
includeShorthandDestructuring
Apr 6, 2018
Merged

findAllReferences: forEachRelatedSymbol can always include shorthand destructuring#23223
2 commits merged into
masterfrom
includeShorthandDestructuring

Conversation

@ghost
Copy link
Copy Markdown

@ghost ghost commented Apr 6, 2018

Sequel to #23028: turns out this parameter isn't needed.

@ghost ghost requested a review from sheetalkamat April 6, 2018 18:57
@ghost
Copy link
Copy Markdown
Author

ghost commented Apr 6, 2018

Sorry, should have run rename tests too -- some tests do change, though I think in a beneficial way. If we're at a location with both property and local meaning (e.g. at x in for ({ x } in y)) we will rename both.

@ghost ghost merged commit 9762598 into master Apr 6, 2018
@ghost ghost deleted the includeShorthandDestructuring branch April 6, 2018 23:30
@microsoft microsoft locked and limited conversation to collaborators Jul 25, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant