Only include unique symbols when getting index types for access checks#23145
Merged
Conversation
ahejlsberg
approved these changes
Apr 4, 2018
Member
ahejlsberg
left a comment
There was a problem hiding this comment.
Approved with the suggested change.
| } | ||
| else { | ||
| return getUnionType(filter(originalKeys, isTypeString)); | ||
| } |
Contributor
|
@weswigham please port to release-2.8 as well. |
weswigham
added a commit
to weswigham/TypeScript
that referenced
this pull request
Apr 5, 2018
microsoft#23145) * Only include unique symbols when getting index types for access checks * Filter all nonstrings * Inline ternary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Alternative to #23090 that moves towards the
indexoftype we talked about the other day, but is lightweight enough to be more acceptable as a patch. Note that this only removes/fixes symbols -numberliterals from late bound symbols will still be an issue (though they've been an issue for longer and need to have more confusing behavior, so probably should wait for the fullindexofimplementation).