Mark js-assignment functions' symbols as methods#23078
Merged
Merged
Conversation
This make display more accurate: 1. The functions now print as methods 2. When the type of the function references the class, the type of the function itself is now printed correctly instead of as `any`.
ghost
approved these changes
Apr 2, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a better fix than #23068 and #22935 because it makes js-assigned functions work more like methods, so they reuse more of the existing method machinery.
This make display more accurate:
any.Other benefits:
isMethodLikeno longer needs to have a js special case.Downsides: