Fix bug: ClassDeclaration not guaranteed to be first declaration of a class#22983
Merged
3 commits merged intoMar 29, 2018
Merged
Conversation
| ////new C().x = 0; | ||
|
|
||
| verify.codeFix({ | ||
| description: "Declare property 'foo'", |
Member
There was a problem hiding this comment.
shouldnt this be "x" instead of "foo"
mhegazy
reviewed
Mar 29, 2018
| if (!(symbol && leftExpressionType.flags & TypeFlags.Object && symbol.flags & SymbolFlags.Class)) { | ||
| return undefined; | ||
| } | ||
| const classDeclaration = cast(first(symbol.declarations), isClassLike); |
Contributor
There was a problem hiding this comment.
should we check that we found a class?
Author
There was a problem hiding this comment.
I think it should be guaranteed to exist if the symbol has SymbolFlags.Class.
sheetalkamat
approved these changes
Mar 29, 2018
Author
|
Thanks to #22987 this is now just adding a test. |
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #22479