Fix conditional type variance - #22869
Merged
Anders Hejlsberg (ahejlsberg) merged 7 commits intoMar 26, 2018
Merged
Conversation
Anders Hejlsberg (ahejlsberg)
requested review from
Daniel Rosenwasser (DanielRosenwasser) and
Mohamed Hegazy (mhegazy)
March 25, 2018 18:40
Member
Author
|
Daniel Rosenwasser (@DanielRosenwasser) Mohamed Hegazy (@mhegazy) I think we should include this one in 2.8.1. |
Contributor
|
it is a bit late for 2.8.1, but should be in 2.8.2 |
Mohamed Hegazy (mhegazy)
approved these changes
Mar 26, 2018
Anders Hejlsberg (ahejlsberg)
added a commit
that referenced
this pull request
Mar 26, 2018
Fix conditional type variance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a missing type relationship for conditional types: Two conditional types
T1 extends U1 ? X1 : Y1andT2 extends U2 ? X2 : Y2are related ifT1andT2is related to the other,U1andU2are identical types,X1is related toX2, andY1is related toY2.Fixes #22860.